The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Call to equals() comparing different types in junitx.ddtunit.DDTTestCase.validateAsserts(boolean) | CORRECTNESS | EC_UNRELATED_TYPES | 427 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method junitx.ddtunit.DDTTestResult.copyContent(TestResult) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 140 | Medium |
| Method junitx.ddtunit.DDTTestResult.createTestResult() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 168 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| junitx.ddtunit.data.DefaultComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 5-16 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| junitx.ddtunit.data.ExceptionAsserter.clone() does not call super.clone() | BAD_PRACTICE | CN_IDIOM_NO_SUPER_CALL | 115-118 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| junitx.ddtunit.data.ObjectAsserter.clone() does not call super.clone() | BAD_PRACTICE | CN_IDIOM_NO_SUPER_CALL | 359-362 | Medium |
| Dead store to assertEx in junitx.ddtunit.data.ObjectAsserter.isArrayContainedinList(RuntimeException) | STYLE | DLS_DEAD_LOCAL_STORE | 336 | High |
| junitx.ddtunit.data.ObjectAsserter doesn't override TypedObject.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 61-362 | Medium |
| The parameter assertEx to junitx.ddtunit.data.ObjectAsserter.isArrayContainedinList(RuntimeException) is dead upon entry but overwritten | CORRECTNESS | IP_PARAMETER_IS_DEAD_BUT_OVERWRITTEN | 336 | High |
| Null pointer dereference of assertEx in junitx.ddtunit.data.ObjectAsserter.validate(boolean) | CORRECTNESS | NP_ALWAYS_NULL | 288 | Medium |
| Possible null pointer dereference of actualText in junitx.ddtunit.data.ObjectAsserter.validate(boolean) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 143 | Medium |
| Possible null pointer dereference of expectedText in junitx.ddtunit.data.ObjectAsserter.validate(boolean) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 149 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: junitx.ddtunit.data.SearchCriteria.defaultComparator | PERFORMANCE | URF_UNREAD_FIELD | 11 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: junitx.ddtunit.data.SearchParameters.defaultComparator | PERFORMANCE | URF_UNREAD_FIELD | 22 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| junitx.ddtunit.data.TypedObject.clone() does not call super.clone() | BAD_PRACTICE | CN_IDIOM_NO_SUPER_CALL | 152-154 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| junitx.ddtunit.data.TypedObjectMap.clone() does not call super.clone() | BAD_PRACTICE | CN_IDIOM_NO_SUPER_CALL | 137-158 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method junitx.ddtunit.data.db.DbDataRestorer.createXml(String) may fail to clean up java.sql.ResultSet | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 164 | Medium |
| Method junitx.ddtunit.data.db.DbDataRestorer.createXml(String) may fail to clean up java.sql.Statement | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 162 | Medium |
| Method junitx.ddtunit.data.db.DbDataRestorer.getObject(String, String) may fail to clean up java.sql.ResultSet | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 288 | Medium |
| Method junitx.ddtunit.data.db.DbDataRestorer.getObject(String, String) may fail to clean up java.sql.Statement | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 285 | Medium |
| Method junitx.ddtunit.data.db.DbDataRestorer.restore(String, String) may fail to clean up java.sql.ResultSet | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 78 | Medium |
| Method junitx.ddtunit.data.db.DbDataRestorer.restore(String, String) may fail to clean up java.sql.Statement | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 76 | Medium |
| junitx.ddtunit.data.db.DbDataRestorer.createXml(String) may fail to close PreparedStatement | BAD_PRACTICE | ODR_OPEN_DATABASE_RESOURCE | 162 | Medium |
| junitx.ddtunit.data.db.DbDataRestorer.getObject(String, String) may fail to close PreparedStatement | BAD_PRACTICE | ODR_OPEN_DATABASE_RESOURCE | 285 | Medium |
| junitx.ddtunit.data.db.DbDataRestorer.restore(String, String) may fail to close PreparedStatement | BAD_PRACTICE | ODR_OPEN_DATABASE_RESOURCE | 76 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Uninitialized read of attrMap in new junitx.ddtunit.data.processing.ActionBase(Map) | CORRECTNESS | UR_UNINIT_READ | 96 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of testDataSet in junitx.ddtunit.data.processing.ActionBase$ObjectReferenceInfo.resolve(IDataSet, String, String) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 492 | Medium |
| Should junitx.ddtunit.data.processing.ActionBase$ObjectReferenceInfo be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 459-530 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Field ArrayCreatorAction.log masks field in superclass junitx.ddtunit.data.processing.ActionBase | CORRECTNESS | MF_CLASS_MASKS_FIELD | 58-221 | High |
| Load of known null value in junitx.ddtunit.data.processing.ArrayCreatorAction.inject() | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 217 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Field AttributeListCreatorAction.log masks field in superclass junitx.ddtunit.data.processing.ActionBase | CORRECTNESS | MF_CLASS_MASKS_FIELD | 49-140 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to param in junitx.ddtunit.data.processing.BeanCreatorAction.processSuccessor(IAction) | STYLE | DLS_DEAD_LOCAL_STORE | 181 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to rootAction in junitx.ddtunit.data.processing.CallCreatorAction.process() | STYLE | DLS_DEAD_LOCAL_STORE | 108 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Field CollectionCreatorAction.log masks field in superclass junitx.ddtunit.data.processing.ActionBase | CORRECTNESS | MF_CLASS_MASKS_FIELD | 59-238 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method call in junitx.ddtunit.data.processing.CollectionCreatorAction$CollectionReferenceInfo.resolve(IDataSet, String, String) passes null for nonnull parameter of doResolution(IDataSet) | CORRECTNESS | NP_NULL_PARAM_DEREF | 271 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to rootAction in junitx.ddtunit.data.processing.ConstantCreatorAction.process() | STYLE | DLS_DEAD_LOCAL_STORE | 105 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Call to method of static java.text.DateFormat in junitx.ddtunit.data.processing.DateCreatorAction$DateFactory.create(String, String, String, String) | MT_CORRECTNESS | STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE | 207 | Medium |
| Call to method of static java.text.DateFormat in junitx.ddtunit.data.processing.DateCreatorAction$DateFactory.create(String, String, String, String) | MT_CORRECTNESS | STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE | 207 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| junitx.ddtunit.data.processing.HintTypes.equals(Object) checks for operand being a String | BAD_PRACTICE | EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS | 124 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method call in junitx.ddtunit.data.processing.MapCreatorAction$MapValueReferenceInfo.resolve(IDataSet, String, String) passes null for nonnull parameter of doResolution(IDataSet) | CORRECTNESS | NP_NULL_PARAM_DEREF | 238 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| junitx.ddtunit.data.processing.ParserConstants.XML_IGNORE_ELEM should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 74 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to refInfo in junitx.ddtunit.data.processing.SubelementCreatorAction.processNoSuccessor() | STYLE | DLS_DEAD_LOCAL_STORE | 139 | Medium |
| Method junitx.ddtunit.data.processing.SubelementCreatorAction.processSuccessor(IAction) invokes inefficient new Character(char) constructor; use Character.valueOf(char) instead | PERFORMANCE | DM_NUMBER_CTOR | 242 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method call in junitx.ddtunit.data.processing.SubelementCreatorAction$SubelementReferenceInfo.resolve(IDataSet, String, String) passes null for nonnull parameter of doResolution(IDataSet) | CORRECTNESS | NP_NULL_PARAM_DEREF | 302 | Medium |
| Should junitx.ddtunit.data.processing.SubelementCreatorAction$SubelementReferenceInfo be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 287-358 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method new junitx.ddtunit.data.processing.TypeAbbreviator() may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 68 | Medium |
| new junitx.ddtunit.data.processing.TypeAbbreviator() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 68 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name junitx.ddtunit.data.processing.parser.EntityResolver shadows the simple name of implemented interface org.xml.sax.EntityResolver | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_INTERFACE | 55-105 | Medium |
| Method junitx.ddtunit.data.processing.parser.EntityResolver.resolveEntity(String, String) may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 94 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name junitx.ddtunit.data.processing.parser.ErrorHandler shadows the simple name of implemented interface org.xml.sax.ErrorHandler | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_INTERFACE | 67-137 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method call in junitx.ddtunit.util.ClassAnalyser.getPrimitiveArrayBaseType(Class) passes null for nonnull parameter of getPrimitiveClass(Class) | CORRECTNESS | NP_NULL_PARAM_DEREF | 629 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method junitx.ddtunit.util.DDTConfiguration.load(String) may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 150 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| junitx.ddtunit.util.DDTDateFormat doesn't override java.text.SimpleDateFormat.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 47-56 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Load of known null value in junitx.ddtunit.util.PrivilegedAccessor.setFieldValue(Object, String, Object) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 73 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| junitx.framework.Assert.assertNotEquals(String, boolean, boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 305 | Medium |
| Method junitx.framework.Assert.assertNotEquals(String, byte, byte) invokes inefficient new Byte(byte) constructor; use Byte.valueOf(byte) instead | PERFORMANCE | DM_NUMBER_CTOR | 152 | Medium |
| Method junitx.framework.Assert.assertNotEquals(String, char, char) invokes inefficient new Character(char) constructor; use Character.valueOf(char) instead | PERFORMANCE | DM_NUMBER_CTOR | 171 | Medium |
| Method junitx.framework.Assert.assertNotEquals(String, int, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 248 | Medium |
| Method junitx.framework.Assert.assertNotEquals(String, long, long) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 267 | Medium |
| Method junitx.framework.Assert.assertNotEquals(String, short, short) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead | PERFORMANCE | DM_NUMBER_CTOR | 286 | Medium |
| The class name junitx.framework.Assert shadows the simple name of the superclass junit.framework.Assert | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 78-380 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name junitx.framework.AssertionFailedError shadows the simple name of the superclass junit.framework.AssertionFailedError | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 88-156 | High |